Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Ember version and use new Embroider testing setup #217

Merged
merged 18 commits into from Oct 25, 2021

Conversation

knownasilya
Copy link
Contributor

No description provided.

@knownasilya
Copy link
Contributor Author

Current issue when running npm start:

Class extends value undefined is not a constructor or null


Stack Trace and Error Report: /var/folders/g5/dvq_p0010s5b2ys8bwd7czdr0000gp/T/error.dump.19f81a4f30f4060237c5ca0b4c83609d.log
An error occurred in the constructor for ember-qunit at /Users/iradchenko/maintained/ember-page-title/node_modules/ember-qunit

Stack trace and details:

stack trace
ERROR Summary:
  • broccoliBuilderErrorStack: [undefined]
  • code: [undefined]
  • codeFrame: [undefined]
  • errorMessage: Class extends value undefined is not a constructor or null
  • errorType: [undefined]
  • location:
    • column: [undefined]
    • file: [undefined]
    • line: [undefined]
  • message: Class extends value undefined is not a constructor or null
  • name: TypeError
  • nodeAnnotation: [undefined]
  • nodeName: [undefined]
  • originalErrorMessage: [undefined]
  • stack: TypeError: Class extends value undefined is not a constructor or null
    at Object. (/Users/iradchenko/maintained/ember-page-title/node_modules/webpack/lib/MainTemplate.js:56:45)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object. (/Users/iradchenko/maintained/ember-page-title/node_modules/webpack/lib/Compilation.js:24:22)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)

@raido
Copy link
Contributor

raido commented Oct 2, 2021

Any updates here? If you are occupied, I can try to update this branch to Ember v3.28 and hopefully get it ready for merge.

@knownasilya
Copy link
Contributor Author

Yes please @raido

@raido
Copy link
Contributor

raido commented Oct 24, 2021

I began working on this and bumping it to Ember 3.28.x.

@raido
Copy link
Contributor

raido commented Oct 24, 2021

Getting back on track plan:

Tier 1:

  1. We merge this, get builds greenish as beta scenario is allowed to fail
  2. Cherry pick or ask author to only do assign related changes in this PR - Resolve deprecation re: use Object.assign or spread instead of Ember.… #218
  3. Release a major version v7.x, because this PR drops Node 10

Tier 2:

  1. I'll open PR for Embroider ember-auto-import 2.x upgrade
  2. Release another major version
  3. Get ember-page-title updated to v8.x for cli blueprints.

cc @knownasilya

@raido raido mentioned this pull request Oct 24, 2021
@raido raido marked this pull request as ready for review October 24, 2021 20:26
@knownasilya knownasilya merged commit 6dcfd68 into master Oct 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/update branch October 25, 2021 17:48
@raido
Copy link
Contributor

raido commented Oct 25, 2021

I lifted my comment into tracking issue - #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants