Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export pageTitle from index #262

Merged
merged 1 commit into from Oct 31, 2023

Conversation

gossi
Copy link
Contributor

@gossi gossi commented Sep 25, 2023

For sweeter usage from gjs/gts file, especially since ember-route-template exists now, you can write this:

import { pageTitle } from 'ember-page-title';

<template>
  {{pageTitle "About"}}
  
  ...
</template>

because nobody has time for this:

import pageTitle from 'ember-page-title/helpers/page-title';

<template>
  {{pageTitle "About"}}
  
  ...
</template>

which also feels like calling internal, forbidden API (though, yeah I know isn't - but still feels like).

addon/package.json Outdated Show resolved Hide resolved
@gossi
Copy link
Contributor Author

gossi commented Sep 29, 2023

As much as I felt required to update embroider at the addon itself, the test-app needs to bump to the latest embroider, too. If this has happened, this PR can continue 👍

@NullVoxPopuli
Copy link
Contributor

I'm a big fan of this

@NullVoxPopuli
Copy link
Contributor

Any chance you can fix C.I. in another PR? looks unrelated

@knownasilya
Copy link
Contributor

knownasilya commented Sep 30, 2023

Not sure what's up with the tests, they keep timing out.. like they pass but time out after?

@NullVoxPopuli
Copy link
Contributor

looks like embroider/test-setup may need to be updated

@NullVoxPopuli
Copy link
Contributor

a basically no-op change here has CI fully passing, #265

so I think the @embroider/addon-dev change caused the failures. I'll address in a separate PR

@NullVoxPopuli NullVoxPopuli merged commit ef95e0b into ember-cli:master Oct 31, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants