Improve return type of getPageTitle test helper
#288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
commented
Feb 15, 2024
| @@ -1,17 +1,17 @@ | |||
| // Testem appends progress to the title... | |||
| // and there's no way to stop this at the moment | |||
|
|
|||
| export function getPageTitle(doc: Document) { | |||
| export function getPageTitle(doc?: Document): string { | |||
There was a problem hiding this comment.
doc should not be required because of doc || window.document.
There was a problem hiding this comment.
Current return type is string | false | undefined because of the current implementation. Using string and updating the implementation seems better. Technically, a breaking change though.
| element instanceof HTMLTitleElement && | ||
| element.innerText.trim().replace(/^\(\d+\/\d+\)/, '') | ||
| ); | ||
| if (element instanceof HTMLTitleElement) { |
There was a problem hiding this comment.
This is much easier to read, thank you!
NullVoxPopuli
approved these changes
Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.