Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks ember new #385

Open
NullVoxPopuli opened this issue Jan 22, 2022 · 2 comments
Open

Breaks ember new #385

NullVoxPopuli opened this issue Jan 22, 2022 · 2 comments

Comments

@NullVoxPopuli
Copy link

Initially reported here: emberjs/ember.js#19912

During my testing the following works (after removing ember-cli-terser so I could see errors clearly):

  • removing the WelcomePage invocation
  • using components from within the app
  • using components from v1 addons
  • using components from v2 addons (ember-stargate / ember-component-statechart (manage))
@NullVoxPopuli NullVoxPopuli mentioned this issue Jan 22, 2022
Closed
SergeAstapov added a commit to SergeAstapov/ember-cli-fastboot that referenced this issue Jan 24, 2022
@SergeAstapov
Remove ember-welcome-page from mocha test
aaec250 
This is due to ember-cli/ember-welcome-page#385 which breaks `ember new`
SergeAstapov added a commit to SergeAstapov/ember-cli-fastboot that referenced this issue Jan 24, 2022
@SergeAstapov
Remove ember-welcome-page from mocha test
81a11fd 
This is due to ember-cli/ember-welcome-page#385 which breaks `ember new`
@kategengler
Copy link
Member

I believe this is the likely cause https://github.com/ember-cli/ember-welcome-page/blob/master/addon-main.js#L10

It intentionally removes itself from production builds, so the invocation errors.

@NullVoxPopuli
Copy link
Author

is there a way to have a build-time error instead of runtime?

@styfle styfle mentioned this issue Aug 15, 2023
Merged
styfle added a commit to vercel/vercel that referenced this issue Aug 15, 2023
@styfle
[examples] update ember example (#10347)
a93e1a7 
This PR updates the ember example using the following:

```
npx ember new ember-quickstart --lang en
```

I also had to add `{ 'ember-welcome-page': { enabled: true } }` to the
build config because the `<WelcomePage>` only works in dev, but throws
when using the default build command:

```
ember build --environment=production
```

For posterity, the error looks like:
```
Uncaught TypeError: Cannot destructure property 'manager' of 'e' as it is null.
    at u.resolvedComponent (vendor-2e12520b7a71eead28708a24fafa7fbc.js:2094:28)
    at vendor-2e12520b7a71eead28708a24fafa7fbc.js:1999:5
    at ne (vendor-2e12520b7a71eead28708a24fafa7fbc.js:1999:30)
    at l (vendor-2e12520b7a71eead28708a24fafa7fbc.js:1991:18)
    at vendor-2e12520b7a71eead28708a24fafa7fbc.js:1981:836
    at _.compile (vendor-2e12520b7a71eead28708a24fafa7fbc.js:1938:173)
    at re (vendor-2e12520b7a71eead28708a24fafa7fbc.js:1991:61)
    at vendor-2e12520b7a71eead28708a24fafa7fbc.js:1988:30
    at ee.compile (vendor-2e12520b7a71eead28708a24fafa7fbc.js:1989:23)
    at Object.evaluate (vendor-2e12520b7a71eead28708a24fafa7fbc.js:2431:224)
```

- Related emberjs/ember.js#19912
- Related ember-cli/ember-welcome-page#385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NullVoxPopuli @kategengler