fix: destructured access in no-controller-access-in-routes rule

ember-cli · Aug 16, 2021 · 629bdf3 · 629bdf3
1 parent 516b699
commit 629bdf3
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 0 deletions.
diff --git a/lib/rules/no-controller-access-in-routes.js b/lib/rules/no-controller-access-in-routes.js
@@ -154,6 +154,24 @@ module.exports = {
           currentRouteNode = null;
         }
       },
+
+      VariableDeclarator(node) {
+        if (!currentRouteNode) {
+          return;
+        }
+
+        if (node.init.type !== 'ThisExpression' || node.id.type !== 'ObjectPattern') {
+          return;
+        }
+
+        const controllerProperty = node.id.properties.find(
+          (prop) => prop.key.type === 'Identifier' && prop.key.name === 'controller'
+        );
+        if (controllerProperty) {
+          // Example: const { controller } = this;
+          context.report({ node: controllerProperty, message: ERROR_MESSAGE });
+        }
+      },
     };
   },
 };

diff --git a/tests/lib/rules/no-controller-access-in-routes.js b/tests/lib/rules/no-controller-access-in-routes.js
@@ -57,6 +57,17 @@ ruleTester.run('no-controller-access-in-routes', rule, {
         }
       });
     `,
+    `
+      import Route from '@ember/routing/route';
+      export default Route.extend({
+        actions: {
+          myAction() {
+            const { foo } = this;
+            const { controller } = bar;
+          },
+        },
+      });
+    `,
 
     `
       import Component from '@ember/component';
@@ -277,5 +288,19 @@ ruleTester.run('no-controller-access-in-routes', rule, {
       output: null,
       errors: [{ message: ERROR_MESSAGE, type: 'CallExpression' }],
     },
+    {
+      code: `
+        import Route from '@ember/routing/route';
+        import { action } from '@ember/object';
+        export default class MyRoute extends Route {
+          @action
+          myAction() {
+            const { controller } = this;
+          }
+        }
+      `,
+      output: null,
+      errors: [{ message: ERROR_MESSAGE, type: 'Property' }],
+    },
   ],
 });