fix: crash in no-controller-access-in-routes

ember-cli · Aug 17, 2021 · a10df4a · a10df4a
1 parent d0a7a73
commit a10df4a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/rules/no-controller-access-in-routes.js b/lib/rules/no-controller-access-in-routes.js
@@ -160,7 +160,12 @@ module.exports = {
           return;
         }
 
-        if (node.init.type !== 'ThisExpression' || node.id.type !== 'ObjectPattern') {
+        if (
+          !node.init ||
+          node.init.type !== 'ThisExpression' ||
+          !node.id ||
+          node.id.type !== 'ObjectPattern'
+        ) {
           return;
         }
 

diff --git a/tests/lib/rules/no-controller-access-in-routes.js b/tests/lib/rules/no-controller-access-in-routes.js
@@ -65,6 +65,12 @@ ruleTester.run('no-controller-access-in-routes', rule, {
             const { foo } = this;
             const { controller } = bar;
           },
+          myAction2() {
+            const controller = this;
+          },
+          myAction3() {
+            let controller4;
+          },
         },
       });
     `,