New rule: no-reserved-imports

[michalsnik]

According to https://github.com/ember-cli/ember-rfc176-data I think we can add a rule that will check if reserved identifiers like Object are being imported.

Incorrect:

import Object from '@ember/object';

Correct:

import EmberObject from '@ember/object';

All reserved keys are here: https://github.com/ember-cli/ember-rfc176-data/blob/master/reserved.json

[michalsnik]

cc @Turbo87 ☝️

[t-sauer]

You can already do this with ESLint with this rule:

'no-shadow': ['error', { 'builtinGlobals': true }]

[michalsnik]

Oh, true @t-sauer. Then I think we should add this to recommended config.

[Turbo87]

Then I think we should add this to recommended config.

that would require a breaking change release again and I'm very much against that in the foreseeable future. IMHO we should only do breaking change releases if we actually need to break how a rule behaves, the recommended config should ideally live outside of this repo/project.

[Turbo87]

@t-sauer the potential advantage of having a custom rule would be that it can be --fix-able, but it's probably not worth it in this case 🤔

[kevinkucharczyk]

I found that there was a similar suggestion made to the Airbnb eslint base and it was not merged, with this as the reasoning: airbnb/javascript#667 (comment)
So similarly, I don't think we should be including the builtinGlobals option in our configuration.

[jbandura]

I think that having a dedicated fixable rule just for the ember object, string, etc. might be a good idea, I'd personally find it valuable.

[michalsnik]

Ok, so it looks like indeed having a dedicated rule will be most valuable in this case.

[jbandura]

Picking this up then - will probably make a PR around saturday/sunday