Super call missing arguments in some rule docs #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You should call `super` with `...arguments` otherwise bad things happen.
bmish
reviewed
Sep 7, 2021
bmish
changed the title
classic-decorator-hooks rule doc
bmish
changed the title
classic-decorator-hooks rule docclassic-decorator-hooks rule doc
fix: add `...args` to the constructor as param.
StephanH90
commented
Sep 8, 2021
|
Shouldn't we also fix |
but I'm new to Ember and I'm not sure if this is correct:
```javascript
export default class MyComponent extends Component {
init(...args) {
this._super(args);
}
willDestroy() {} // Both a classic and Glimmer component lifecycle hook
}
```
bmish
requested changes
Sep 9, 2021
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
bmish
changed the title
classic-decorator-hooks rule doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You should call
superwith...argumentsotherwise bad things happen.