Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow concise ArrowFunctionExpression (named-functions-in-promises) #64

Merged
merged 9 commits into from May 23, 2017
Merged

Allow concise ArrowFunctionExpression (named-functions-in-promises) #64

merged 9 commits into from May 23, 2017

Commits on May 19, 2017

  1. Allow concise ArrowFunctionExpression (named-functions-in-promises)

    @sudowork
    sudowork committed May 19, 2017
    Configuration menu
    Copy the full SHA
    970cb30 View commit details
    Browse the repository at this point in the history

  2. Ensure CallExpression is calling a method on the parent object 

    This is to ensure that the promise handler is defined as a method on the
parent object and not some other object.
    @sudowork
    sudowork committed May 19, 2017
    Configuration menu
    Copy the full SHA
    57b8ceb View commit details
    Browse the repository at this point in the history

  3. Fix destructuring

    @sudowork
    sudowork committed May 19, 2017
    Configuration menu
    Copy the full SHA
    148c0d0 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2017

  1. Drop requirement that method is called on this

    @sudowork
    sudowork committed May 20, 2017
    Configuration menu
    Copy the full SHA
    4d01fda View commit details
    Browse the repository at this point in the history

  2. Make allowing concise arrow expressions optional

    @sudowork
    sudowork committed May 20, 2017
    Configuration menu
    Copy the full SHA
    8cfcdc8 View commit details
    Browse the repository at this point in the history

  3. Document allowConciseArrow option (named-functions-in-promises)

    @sudowork
    sudowork committed May 20, 2017
    Configuration menu
    Copy the full SHA
    997edf8 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2017

  1. Address Code Review Comments 

    - Rename `allowConciseArrow` to `allowSimpleArrowFunction`
- Update documentation for `allowSimpleArrowFunction`
- Move `isConciseArrowFunctionWithCallExpression` to utils
- Add unit test for `isConciseArrowFunctionWithCallExpression`
- Add invalid test cases for arrow functions with bodies when
  `allowSimpleArrowFunction` is set to true
    @sudowork
    sudowork committed May 23, 2017
    Configuration menu
    Copy the full SHA
    3264c37 View commit details
    Browse the repository at this point in the history

  2. Update isConciseArrowFunctionWithCallExpression test name

    @sudowork
    sudowork committed May 23, 2017
    Configuration menu
    Copy the full SHA
    c940ab2 View commit details
    Browse the repository at this point in the history

  3. Add test case for block body

    @sudowork
    sudowork committed May 23, 2017
    Configuration menu
    Copy the full SHA
    cbb5d33 View commit details
    Browse the repository at this point in the history