Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decorator support to no-unnecessary-service-injection-argument rule #781

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Add decorator support to no-unnecessary-service-injection-argument rule #781

merged 1 commit into from
Apr 14, 2020

Conversation

bmish
Copy link
Member

@bmish bmish commented Apr 14, 2020 •
edited

Handles decorator usage and autofixes.

Before:

class Test { @service("serviceName") serviceName }

After:

class Test { @service() serviceName }

Helps with #560 #566.

@bmish bmish merged commit ad0b68f into ember-cli:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bmish