@required vs required

[Turbo87]

The codemod is currently converting required arguments to required attributes, instead of @required arguments. This might be fine for <Input> (is it?), but certainly not for all components.

The same applies for placeholder vs. @placeholder.

The codemod also does something similar for class, but I suspect in that case it should be fine.

[rwjblue]

Ya, we should fix this. We can build in assumptions about Ember's built-in components, but we cannot make any assumptions about the others.

tldr; IMHO, this codemod should not be migrating away from arguments to attributes in non-built-in components.

[Turbo87]

@rwjblue how do you feel about class?

[rwjblue]

It depends on what level of "safety" we are shooting for. class is absolutely a value that folks might use and munge in their JS, and assuming that their JS does not need access to it is conceptually breaking.

[Turbo87]

I had similar thoughts but then couldn't come up with a realistic scenario where it actually mattered for the class attribute. But I'm fine either way. the safest way is definitely to pass it as an argument instead of attribute.

[tylerturdenpants]

SO as an example, it should not do:

{{foo-bar class="baz"}}

to

<FooBar class="baz"/>

but rather

<FooBar @class="baz"/>

correct?

[Turbo87]

@tylerturdenpants yeah, exactly. except maybe for builtin components like input and textarea.

[tylerturdenpants]

Ok. Crystal clear now. Thanks.