Move helper disambiguation to a flag that is off by default #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolmaus
force-pushed
the
opt-in-for-unambiguous-helpers
branch
from
e427175
to
9c5ab2b
Compare
lolmaus
force-pushed
the
opt-in-for-unambiguous-helpers
branch
from
9c5ab2b
to
882c956
Compare
|
@mansona There's a failing integration test that I struggle with. I've used the pre-unambiguous input and actual output (obtainedvia a unit test). Not sure what's wrong. As for the covergate decrease, it may be caused by your decision to have only one test with flag enabled, so not all code paths are executed. |
mansona
requested changes
Feb 6, 2024
| @@ -3,15 +3,15 @@ | |||
| <h3 class="sr-only"> | |||
| Components | |||
| </h3> | |||
| {{#bs-nav type="pills" stacked=true as |nav|}} | |||
| <BsNav @type="pills" @stacked={{true}} as |nav|> | |||
There was a problem hiding this comment.
This probably needs to go back to curly invocation for the input
| @@ -1,2 +1,2 @@ | |||
| <div>this template has no js </div> | |||
| {{#bs-button type="primary"}}Primary{{/bs-button}} | |||
| <BsButton @type="primary">Primary</BsButton> | |||
There was a problem hiding this comment.
same as above - curly invocation
| @@ -1,9 +1,9 @@ | |||
| {{site-header user=this.user class=(if this.user.isAdmin "admin")}} | |||
| <SiteHeader @user={{this.user}} @class={{if this.user.isAdmin "admin"}} /> | |||
There was a problem hiding this comment.
same as above - curly invocation
| tagName.includes && | ||
| (tagName.includes('/') || (tagName.includes('-') && tagName.includes('.'))) | ||
| ); | ||
| function isNestedComponentTagName(tagName, unambiguousHelpers = false) { |
There was a problem hiding this comment.
I don't quite understand the need for this function to change, if we do need it then we should probably add a comment to leave some help for future us 😂
lolmaus
force-pushed
the
opt-in-for-unambiguous-helpers
branch
from
0d0518e
to
7629558
Compare
…rt glimmer components
lolmaus
force-pushed
the
opt-in-for-unambiguous-helpers
branch
from
7629558
to
ab2a93c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514. Fixes #504.