Support for multiple decorators

[ssutar]

• Support for multiple decorators
• Handle the different decorator corner cases
• Replace the imports with appropriate paths from ember-decorators

Introduced a new class EOProp.js, a wrapper for EmberObjectProperty to avoid mutating the ClassProperty object returned from jscodeshift parser

[pzuraq]

Looking good, I like the direction of abstracting the EOProp class, thinking maybe we can start adding some more classes to normalize the rest of the abstractions (in future PRs though).

Couple minor comments, once those are addressed we should be good to go

[pzuraq]

This will need to be made a native getter get isEnabled()

[ssutar]

Yeah, looks little complicated to make a decision whether to make native getter. Should it be just if the property has multiple decorators the value should be either simple value or native getter? 🤔

[pzuraq]

If it is marked by @computed, it will always need to be a native getter. @className can also only ever be applied to a native getter, or a class field, neither works with methods.

If it is an @action it should be a method. I don't believe there are any other method decorators.

In general, method decorators and accessor/field decorators are pretty mutually exclusive at this point. You don't have decorators that apply to both types, just one or the other.

[ssutar]

Hmm, that means the this transform is incorrect in the decorators.output.js

/**
  Computed description
  */
  @computed("fullName", "age", "country")
  description() {
    return `${this.get(
      "fullName"
    )}; Age: ${this.get("age")}; Country: ${this.get("country")}`;
  }

It should be

/**
  Computed description
  */
  @computed("fullName", "age", "country")
  get description() {
    return `${this.get(
      "fullName"
    )}; Age: ${this.get("age")}; Country: ${this.get("country")}`;
  }

[ssutar]

I think only action and on are method decorators

[pzuraq]

ah, and @observes, thanks for reminding me about those

[ssutar]

👍

[pzuraq]

Removable?

[ssutar]

Removed