Refactor the import declaration handler #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 5, 2019 18:13
- Moved the logic to a new helper module import-helper.js - Refactored the bulky functions and updated comments
pzuraq
approved these changes
Feb 7, 2019
|
Generally looks good, another thing is once we switch to the polyfilled behavior we'll be able to drop a big chunk of this code. I'm going to try to get that working sooner rather than later, we'll see how it goes though. |
ssutar
added a commit
to ssutar/ember-es6-class-codemod
that referenced
this pull request
Feb 12, 2019
* Refactor the import statements logic to make it more readable - Moved the logic to a new helper module import-helper.js - Refactored the bulky functions and updated comments * Fixed a typo * Remove unnecessary delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix following issues as well: #60 #74 and #59