Port filter from ember data and deprecate #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2018
runspired
changed the title
igorT
approved these changes
Apr 18, 2018
LICENSE.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright (c) 2015 | |||
There was a problem hiding this comment.
I don't believe this needs to be updated but not quite sure
|
|
||
| window.EmberENV = window.EmberENV || {}; | ||
| window.EmberENV.ENABLE_DS_FILTER = true; | ||
| export default Store.extend(FilterMixin); |
There was a problem hiding this comment.
Maybe mention something about how this plays with common addons which extend the store?
|
Looks good to me as well, but separating into multiple PRs would be ❤️ ❤️ |
runspired
force-pushed
the
port-filter-from-ember-data
branch
from
7724641
to
7cc6c57
Compare
runspired
force-pushed
the
port-filter-from-ember-data
branch
from
7cc6c57
to
e34da02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to eliminate all
filterimplementation code fromember-dataitself, and deprecates the use ofstore.filter.