Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve popover with different placement for context menu #143

Open
LowBP opened this issue Jul 2, 2019 · 0 comments
Open

Improve popover with different placement for context menu #143

LowBP opened this issue Jul 2, 2019 · 0 comments
Assignees
Milestone

Comments

@LowBP
Copy link
Collaborator

LowBP commented Jul 2, 2019

Describe the bug
Current popover support only 4 different positions (top,bottom,left,right)

To Reproduce
popover

Expected behavior
PopOver should support all position as mentioned bellow .

const VALID_POSITIONS: PopoverPosition[] = [
    PopoverPosition.AUTO,
    PopoverPosition.AUTO_START,
    PopoverPosition.AUTO_END,
    PopoverPosition.TOP_LEFT,
    PopoverPosition.TOP,
    PopoverPosition.TOP_RIGHT,
    PopoverPosition.RIGHT_TOP,
    PopoverPosition.RIGHT,
    PopoverPosition.RIGHT_BOTTOM,
    PopoverPosition.BOTTOM_LEFT,
    PopoverPosition.BOTTOM,
    PopoverPosition.BOTTOM_RIGHT,
    PopoverPosition.LEFT_TOP,
    PopoverPosition.LEFT,
    PopoverPosition.LEFT_BOTTOM,
];

@LowBP LowBP self-assigned this Jul 2, 2019
@LowBP LowBP added this to the 0.8.0 milestone Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant