Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define behavior for preprocessors. #274

Open
nathanhammond opened this issue Nov 28, 2016 · 1 comment
Open

Define behavior for preprocessors. #274

nathanhammond opened this issue Nov 28, 2016 · 1 comment

Comments

@nathanhammond
Copy link
Contributor

nathanhammond commented Nov 28, 2016

Things we know:

  • All assets are present (lazy, eager, and imported) in assets/vendor.css.
  • [BUG] CSS preprocessTree is being invoked twice.
  • [BUG] pre/postprocessTree is only invoked one-level-deep.
  • [BUG] The app folder isn't fully nuked inside of engines.

Things we believe:

  • template and js trees contain only the root assets. (inside of pre/postprocessTree in top-level addon)

Things we don't know:

  • this.import('vendor/addon.css') has all CSS in the entire hierarchy, we thought we noop'd it. Why?
@nathanhammond nathanhammond changed the title Confirm that all engine assets appear in preprocessTree and postprocessTree. Define behavior for preprocessors. Dec 2, 2016
@rwjblue
Copy link
Member

rwjblue commented Jan 14, 2017

All assets are present (lazy, eager, and imported) in assets/vendor.css.

I believe we got somewhat confused on this one, the only assets present in assets/vendor.css were those using app.import (this.import was handled correctly as was thigns in addon/styles of the engine or addon/styles of nested child addons). #314 fixes the app.import issue.

[BUG] CSS preprocessTree is being invoked twice.

PR has been submitted to address this ember-cli/ember-cli#6676.

[BUG] pre/postprocessTree is only invoked one-level-deep.

Has been fixed upstream in ember-cli/ember-cli#6516 and will be released in ember-cli@2.12 (first beta soon).

[BUG] The app folder isn't fully nuked inside of engines.

I'd like to separate that into a separate issue, we should likely prevent engines from having app/ folders.

this.import('vendor/addon.css') has all CSS in the entire hierarchy, we thought we noop'd it. Why?

Same as the first issue, app.import was misbehaving, and should be fixed by #314.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants