Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Engines RFC to reflect developments in and lessons from this addon #33

Closed
5 of 7 tasks
dgeb opened this issue Jan 8, 2016 · 3 comments
Closed
5 of 7 tasks

Comments

@dgeb
Copy link
Member

dgeb commented Jan 8, 2016

  • Document {{mount}} keyword
  • Include as option for mount method to allow engine aliases
  • Should we allow arbitrary configuration attributes to be passed from the consuming application to the engine?
  • What is the long term future of this addon? Can it continue to exist by overriding only public methods?
  • Go further in depth into lazy loading issues (e.g. separation of route serializers)
  • Should we remove the section about potential namespaced access to engines from parents?
  • Discuss synergies with routable components
@knownasilya
Copy link
Contributor

Should we allow arbitrary configuration attributes to be passed from the consuming application to the engine?

That might be nice, but how is it any different from sharing a service? Could you use it to build the engine differently or something?

@dgeb dgeb changed the title Update Engines RFC to reflect developments in this addon Update Engines RFC to reflect developments in and lessons from this addon Jan 16, 2016
@rwjblue
Copy link
Member

rwjblue commented Jan 18, 2016

Discussion from Ember F2F:

Should we allow arbitrary configuration attributes to be passed from the consuming application to the engine?

Yes, the {{mount}} template keyword should allow normal handlebars style hash arguments. The router DSL style should also allow some sort of API to supply parameters too, but the exact API is less obvious.

What is the long term future of this addon? Can it continue to exist by overriding only public methods?

We decided that all overrides should be moved upstream into Ember itself, and that this addon will still continue to exist to provide blueprints/commands/etc as well as be the "single source" for importing Engine.

@dgeb
Copy link
Member Author

dgeb commented May 3, 2016

Closing because the RFC has been merged and the remaining issues are now being tracked separately.

@dgeb dgeb closed this as completed May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants