Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require wrapping addon/routes.js default export to allow upgradability. #64

Closed
rwjblue opened this issue Feb 7, 2016 · 3 comments
Closed

Comments

@rwjblue
Copy link
Member

rwjblue commented Feb 7, 2016

As we learned the hard way in the Ember 1.x series, having plain functions being exported can become quite painful from a compatibility perspective. I would prefer to avoid the mistakes we made with Handlebars helpers, and require that the routes file be wrapped in a helper function so that we have a way to handle compatibility concerns with any future refactors.

import buildRoutes from 'ember-engines/routes';

export default buildRoutes(function() {
  this.route('foo');
  this.route('bar');
});
@rwjblue
Copy link
Member Author

rwjblue commented Feb 7, 2016

@dgeb - Do the above import paths and names look OK to you?

@dgeb
Copy link
Member

dgeb commented Feb 23, 2016

Do the above import paths and names look OK to you?

@rwjblue yeah, that looks good to me.

I agree this is an important change that we should make before releasing v0.2.0

@dgeb
Copy link
Member

dgeb commented Feb 26, 2016

Closed via #73

@dgeb dgeb closed this as completed Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants