Move broccoli-test-helper to devDependencies #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ginomiglio thanks for contribution and sorry for delay. do you mind to refresh your branch as now there is a conflict? |
This file is only used in node-tests/ so it doesn't need to be installed by consuming apps/addons.
ginomiglio
force-pushed
the
use-dev-dependencies-where-possible
branch
from
99c401e
to
5f0cd98
Compare
|
@SergeAstapov done! |
|
Thank you @ginomiglio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is only used in
node-tests/so it doesn't need to be installed by consuming apps/addons. (I noticed this because it was causing my app to include a very old version of ember-cli/watch-detector.)