Convert codebase to use native classes #868
Conversation
| @@ -1,8 +1,8 @@ | |||
| import { inject as service } from '@ember/service'; | |||
| import Route from '@ember/routing/route'; | |||
|
|
|||
| export default Route.extend({ | |||
| exampleService: service(), | |||
| export default class extends Route { | |||
There was a problem hiding this comment.
think the class should be named here
| }, | ||
| }); | ||
| @action goToChineseVersion() { | ||
| this.transitionTo({ queryParams: { lang: 'Chinese' } }); |
There was a problem hiding this comment.
converting this in isolation of the 855 pr change? if yes then that pr will need need to recharge this line to make tests work with e-engines-router-service due to a known bug with qp only transitions
There was a problem hiding this comment.
@void-mAlex sorry I think I missed your point. This PR focuses solely on syntax change, without any functional changes.
Once we land this, we we would simply need to rebase #855, do all the necessary functional tweaks without noise of syntax conversion and land it with sole focus on v5 support via using e-engines-router-service
There was a problem hiding this comment.
Why do we need to merge it before the #855?
There was a problem hiding this comment.
Why do we need to merge it before the #855?
the idea is to not have a mega pr that does everything
@void-mAlex sorry I think I missed your point. This PR focuses solely on syntax change, without any functional changes.
Once we land this, we we would simply need to rebase #855, do all the necessary functional tweaks without noise of syntax conversion and land it with sole focus on v5 support via using e-engines-router-service
my concern is that a decent amount of time will be wasted debugging tests again, which is fine, it's not too daunting, but tried leaving a breadcrumb to one conflict I know we'll have
There was a problem hiding this comment.
tried leaving a breadcrumb to one conflict I know we'll have
noted! will be glad to help
There was a problem hiding this comment.
my concern is that a decent amount of time will be wasted debugging tests again
I agree! would be great to avoid back in forth
|
@SergeAstapov I don't think we need to fix it first before merging the #855 could you please clarify what you're trying to achieve here enriching the PR description? |
SergeAstapov
force-pushed
the
native-classes
branch
from
1043103
to
b3b1e7d
Compare
Extract from #855 to keep it focused