Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup release-plan #872

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Setup release-plan #872

merged 3 commits into from
Apr 3, 2024

Conversation

SergeAstapov
Copy link
Contributor

@SergeAstapov SergeAstapov commented Mar 25, 2024

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@villander villander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should switch our release workflow. it has been working well and I don't see any advantage in using the release plan over what we have in place @SergeAstapov @void-mAlex

@SergeAstapov
Copy link
Contributor Author

@villander release-plan does bit more automation compared to release-it, e.g. release preview PR so worth the shot (if we can make it work reliably easily)

@void-mAlex
Copy link
Collaborator

I don't think we should switch our release workflow. it has been working well and I don't see any advantage in using the release plan over what we have in place @SergeAstapov @void-mAlex

the issue with the current release flow is that it's not possible, due to mainly no npm access to the package

the change to release-plan ensures that npm access can be given only as a GH secret and access managed on GH with correct perissions to merge, it also ensures the builds are correct and reproducible with no human error 'possible' in the process as the only thing it involves are correct pr titles and labels
at the same time we get more automation and control over the release and if there is something else we need release plan to do it's easier to upstream as long as we have the use case.

for those reasons but mainly the ability to centrally release are why we need this before we merge the rest

@villander
Copy link
Member

thanks for the context @void-mAlex that makes sense now. We can move forward @SergeAstapov given the release has been a pain point to us requiring Chris to publish npm package every single time

mansona and others added 2 commits April 3, 2024 10:25
And i committed the missing files
run npm init release-plan-setup@latest
@void-mAlex void-mAlex merged commit 3e89d73 into master Apr 3, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Apr 3, 2024
@SergeAstapov SergeAstapov deleted the release-plan branch April 3, 2024 15:17
@SergeAstapov
Copy link
Contributor Author

Thank you @void-mAlex @mansona !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants