Race condition prevents cleaning of dist folder between rebuilds #246

jurecuhalev · 2016-08-03T07:57:31Z

The first time I run a fastboot on a simple project, it works. Second time it crashes:

➜  moment-fastboot-example git:(master) NODE_DEBUG=fs ember fastboot --serve-assets
Installing FastBoot npm dependencies

Build successful - 12390ms.

Slowest Trees                                 | Total               
----------------------------------------------+---------------------
Babel                                         | 4257ms              
Babel                                         | 2892ms              
Babel                                         | 689ms               

Slowest Trees (cumulative)                    | Total (avg)         
----------------------------------------------+---------------------
Babel (30)                                    | 9917ms (330 ms)     

DEBUG: -------------------------------
DEBUG: Ember      : 2.7.0
DEBUG: Ember Data : 2.7.0
DEBUG: -------------------------------
Ember FastBoot running at http://[::]:3000
^C%                                                                                                                                                                                                                                                                          ➜  moment-fastboot-example git:(master) NODE_DEBUG=fs ember fastboot --serve-assets
Installing FastBoot npm dependencies

Build successful - 2498ms.

Slowest Trees                                 | Total               
----------------------------------------------+---------------------
SourceMapConcat: Concat: Vendor /assets/ve... | 135ms               

Slowest Trees (cumulative)                    | Total (avg)         
----------------------------------------------+---------------------
Babel (30)                                    | 678ms (22 ms)       
SourceMapConcat: Concat: Vendor /asset... (2) | 257ms (128 ms)      
JSHint templates (2)                          | 155ms (77 ms)       

fs.js:88
        throw backtrace;
        ^

Error: ENOTEMPTY: directory not empty, rmdir '/Users/gandalf/hacking/fastboot/moment-fastboot-example/dist/node_modules/moment/src/'
    at rethrow (fs.js:83:21)
    at maybeCallback (fs.js:101:42)
    at Object.fs.rmdir (fs.js:871:14)
    at TreeSync.<anonymous> (/Users/gandalf/hacking/fastboot/moment-fastboot-example/node_modules/tree-sync/index.js:79:19)
    at Array.forEach (native)
    at TreeSync.sync (/Users/gandalf/hacking/fastboot/moment-fastboot-example/node_modules/tree-sync/index.js:50:14)
    at CoreObject.module.exports.Task.extend.copyToOutputPath (/Users/gandalf/hacking/fastboot/moment-fastboot-example/node_modules/ember-cli/lib/models/builder.js:173:10)
    at /Users/gandalf/hacking/fastboot/moment-fastboot-example/node_modules/ember-cli/lib/models/builder.js:187:21
    at lib$rsvp$$internal$$tryCatch (/Users/gandalf/hacking/fastboot/moment-fastboot-example/node_modules/rsvp/dist/rsvp.js:493:16)
    at lib$rsvp$$internal$$invokeCallback (/Users/gandalf/hacking/fastboot/moment-fastboot-example/node_modules/rsvp/dist/rsvp.js:505:17)

Repository that I used to test: https://github.com/gandalfar/moment-fastboot-example

➜  moment-fastboot-example git:(master) ember -v
ember-cli: 2.7.0
node: 6.2.1
os: darwin x64

Connected ticket with a bit more discussion: jasonmit/ember-cli-moment-shim#55

The text was updated successfully, but these errors were encountered:

jurecuhalev · 2016-08-03T08:03:50Z

In addition to that, if I remove dist so it would get regenerated, it fails to regenerated it correctly. It works correctly with ember s.

➜  moment-fastboot-example git:(master) rm -rf dist                  
➜  moment-fastboot-example git:(master) ember fastboot --serve-assets
Installing FastBoot npm dependencies

Build successful - 2703ms.

Slowest Trees                                 | Total               
----------------------------------------------+---------------------
SourceMapConcat: Concat: Vendor /assets/ve... | 135ms               

Slowest Trees (cumulative)                    | Total (avg)         
----------------------------------------------+---------------------
Babel (30)                                    | 728ms (24 ms)       
SourceMapConcat: Concat: Vendor /asset... (2) | 269ms (134 ms)      
JSHint templates (2)                          | 204ms (102 ms)      

There was an error trying to run your application in FastBoot.

This is usually caused by either your application code or an addon trying to access an API that isn't available in Node.js.
Based on the stack trace, it looks like the exception was generated in util.js on line 1007.
The exception is probably coming from your app. Look at this file and line number to determine what is triggering the exception.

The full stack trace is:

spawn /bin/sh ENOENT
Error: spawn /bin/sh ENOENT
    at exports._errnoException (util.js:1007:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:182:32)
    at onErrorNT (internal/child_process.js:348:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

jurecuhalev · 2016-08-03T08:05:29Z

Running ember s also fixes fastboot. So that it runs once correctly again.

Jarred-Sumner · 2016-08-12T00:03:28Z

I'm running into this issue too.

josemarluedke · 2016-08-13T19:53:27Z

I'm also running into this issue.

alidcast · 2016-09-14T17:59:12Z

Is this fixed yet? I also ran into the couldn't find package.json issue. I ran ember build and tried again, and now I'm getting an document is not defined error.

ptomasroos · 2016-09-20T07:40:48Z

I'm having the same problem

marcemira · 2016-09-21T01:35:27Z

Hello, same here! 👋

bigredwill · 2016-10-07T17:57:34Z

There is a fix by @danmcclain #269 github.com/ember-fastboot/ember-cli-fastboot/pull/269

I tested it out and it solves this issue 😄

stefanpenner · 2016-10-07T18:23:03Z

I believe the root cause is, the fastboot server incorrectly serves from dist not from the output of the build. Note, dist is merely a user friendly reflection of the last build (be that test or build or server or ...).

the following would most likely address this issue: #274

and concretely, not having node_modules in dist would also mitigate (atleast the exact failure) #269

danmcclain · 2016-10-07T18:36:52Z

My fix is also temporary until the solution in #274 lands. 274 is the Way of the Future™

stefanpenner · 2016-10-07T18:41:53Z

@danmcclain i believe both are complementary.

josemarluedke · 2016-11-19T20:45:06Z

Hey @danmcclain I think your fix will be necessary to solve this issue.

I just tested out all the work that @kratiahuja has done with building FastBoot in Ember CLI with the hope this problem was solved, however, it did not solve this specific issue.

I have a reproduction here: https://github.com/josemarluedke/fastboot-build-spike which is just a fork from @kratiahuja repo but with an addition of a FastBoot dependency.

@danmcclain @kratiahuja Is there anything I can help with to get it fixed?

@kratiahuja btw, amazing job in the Ember CLI build with FastBoot! \o/

kratiahuja · 2016-11-20T18:06:39Z

@josemarluedke I think this bug still talks about ember fastboot --serve-assets. While my work pushed upstream till now is only on the build part. If you want to test with the build part, you can use this gist.

I have the changes for #274 locally (from ember-cli API side changes) but where we will be able to serve from tmp and not dist directory. However I haven't pushed it upstream yet 😄 . I need to put out an RFC in ember-cli for that.

josemarluedke · 2016-11-20T20:03:36Z

@kratiahuja I see now. Thanks for working on this. Yes, I tested your stuff using your gist, that was very helpful.

Blackening999 · 2016-11-22T10:53:07Z

When I update some file, fastboot crashed and any subsequent attempts to make it work fails until full npm/bower clean and reinstall:

[Blacks-MacBook-Pro 112] ~/Work/My_Projects/proj-fastboot > ember fastboot --serve-assets
DEPRECATION: ember-addon.fastBootDependencies has been replaced with ember-addon.fastbootDependencies [addon: ember-network]
Installing FastBoot npm dependencies

Build successful - 2025ms.



Slowest Nodes (totalTime => 5% )              | Total (avg)         
----------------------------------------------+---------------------
Babel (24)                                    | 653ms (27 ms)       
Concat (16)                                   | 388ms (24 ms)       
Funnel (55)                                   | 183ms (3 ms)        

fs.js:101
      throw err;  // Forgot a callback but don't know where? Use NODE_DEBUG=fs
      ^

Error: ENOTEMPTY: directory not empty, rmdir '/Users/black/Work/My_Projects/proj-fastboot/dist/node_modules/node-fetch/node_modules/iconv-lite/encodings/'
    at Error (native)

danmcclain · 2016-11-22T11:09:53Z

@Blackening999 remove your dist/node_modules folder to get past this. It's because we are still calling npm install in the ember fastboot command

kratiahuja · 2017-03-07T07:20:47Z

This should be solved by #356 . We should close this once that lands.

ptomasroos · 2017-03-07T07:57:05Z

Great news!

stefanpenner · 2017-05-17T17:39:13Z

master (soon rc.1) should address this

1337-ishaan · 2020-05-11T04:53:47Z

**> Cannot find module 'node-fetch' from 'script2.test.js' **

Hey team!
Im getting this error even though i have installed the node-fetch package and also require_d_ it in script2.js and script2.js,
Please help

jasonmit mentioned this issue Aug 3, 2016

Missing package.json during rebuild #247

Closed

steveszc mentioned this issue Aug 24, 2016

Subsequent ember fastboot is failing with "directory not empty" #235

Closed

tomdale mentioned this issue Sep 5, 2016

The Road to 1.0 #98

Closed

38 tasks

danmcclain mentioned this issue Sep 19, 2016

Fastboot server failing with Ember 2.9 #265

Closed

bigredwill mentioned this issue Oct 7, 2016

move/duplicate the npm install section of "deploying your app" to user-guide ember-fastboot/fastboot-website#47

Open

Turbo87 mentioned this issue Feb 6, 2017

Update ember-cli-addon-tests to the latest version 🚀 mainmatter/ember-simple-auth#1198

Merged

simonihmig mentioned this issue Feb 6, 2017

Possible regression after 0.4.2 tomdale/ember-cli-addon-tests#49

Closed

kratiahuja mentioned this issue Mar 7, 2017

Master punch list for resolving Fastboot 1.0 build issues #360

Closed

35 tasks

kratiahuja mentioned this issue Apr 2, 2017

Refactor fastboot build to be more performant #369

Merged

34 tasks

stefanpenner closed this as completed May 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Race condition prevents cleaning of dist folder between rebuilds #246

Race condition prevents cleaning of dist folder between rebuilds #246

jurecuhalev commented Aug 3, 2016 •

edited

jurecuhalev commented Aug 3, 2016

jurecuhalev commented Aug 3, 2016 •

edited

Jarred-Sumner commented Aug 12, 2016 •

edited

josemarluedke commented Aug 13, 2016

alidcast commented Sep 14, 2016

ptomasroos commented Sep 20, 2016

marcemira commented Sep 21, 2016

bigredwill commented Oct 7, 2016

stefanpenner commented Oct 7, 2016 •

edited

danmcclain commented Oct 7, 2016

stefanpenner commented Oct 7, 2016

josemarluedke commented Nov 19, 2016

kratiahuja commented Nov 20, 2016

josemarluedke commented Nov 20, 2016

Blackening999 commented Nov 22, 2016

danmcclain commented Nov 22, 2016

kratiahuja commented Mar 7, 2017

ptomasroos commented Mar 7, 2017

stefanpenner commented May 17, 2017

1337-ishaan commented May 11, 2020

Race condition prevents cleaning of dist folder between rebuilds #246

Race condition prevents cleaning of dist folder between rebuilds #246

Comments

jurecuhalev commented Aug 3, 2016 • edited

jurecuhalev commented Aug 3, 2016

jurecuhalev commented Aug 3, 2016 • edited

Jarred-Sumner commented Aug 12, 2016 • edited

josemarluedke commented Aug 13, 2016

alidcast commented Sep 14, 2016

ptomasroos commented Sep 20, 2016

marcemira commented Sep 21, 2016

bigredwill commented Oct 7, 2016

stefanpenner commented Oct 7, 2016 • edited

danmcclain commented Oct 7, 2016

stefanpenner commented Oct 7, 2016

josemarluedke commented Nov 19, 2016

kratiahuja commented Nov 20, 2016

josemarluedke commented Nov 20, 2016

Blackening999 commented Nov 22, 2016

danmcclain commented Nov 22, 2016

kratiahuja commented Mar 7, 2017

ptomasroos commented Mar 7, 2017

stefanpenner commented May 17, 2017

1337-ishaan commented May 11, 2020

jurecuhalev commented Aug 3, 2016 •

edited

jurecuhalev commented Aug 3, 2016 •

edited

Jarred-Sumner commented Aug 12, 2016 •

edited

stefanpenner commented Oct 7, 2016 •

edited