Only start app once, call fastboot.reload#269
Merged
danmcclain merged 2 commits intomasterfrom Feb 10, 2017
Merged
Conversation
danmcclain
force-pushed
the
remove-npm-install-from-watch
branch
from
ea8d0b5 to
7378c3c
Compare
Contributor
👍 |
danmcclain
force-pushed
the
remove-npm-install-from-watch
branch
2 times, most recently
from
1ee9569 to
e324913
Compare
danmcclain
force-pushed
the
remove-npm-install-from-watch
branch
from
e324913 to
2726118
Compare
danmcclain
force-pushed
the
remove-npm-install-from-watch
branch
from
2726118 to
1c26e20
Compare
fivetanley
force-pushed
the
remove-npm-install-from-watch
branch
from
1c26e20 to
f86036b
Compare
rwjblue
force-pushed
the
remove-npm-install-from-watch
branch
from
4d24e0c to
1badeaf
Compare
Member
|
Rebased against recent updates to package.json by @kellyselden (which included ember-addon-tests bump) |
Member
|
😕 |
Contributor
|
Hey @danmcclain could you outline what changes in the tests needs to happen so we can land this PR? I'm happy to work in updating these tests if I have more information and a path forward. Thanks. |
Member
Author
|
@josemarluedke the tests are updated, we just need to conquer Travis, @rwjblue promised me he'd dig in, just need to bug him 🧌 |
danmcclain
added a commit
that referenced
this pull request
Jan 21, 2017
Use npm 3 in travis to solve tests for #269
danmcclain
force-pushed
the
remove-npm-install-from-watch
branch
2 times, most recently
from
ed38a17 to
f70febc
Compare
Remove `npm install` from watch cycle As @ef4 pointed out, it's not required, as the node_modules in the root of the project will be used
danmcclain
force-pushed
the
remove-npm-install-from-watch
branch
from
f70febc to
80b014d
Compare
danmcclain
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
npm installfrom watch cycleAs @ef4 pointed out, it's not required, as the node_modules in the root
of the project will be used
Need to update tests