Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop module unification support #825

Merged
merged 1 commit into from
May 28, 2021
Merged

Drop module unification support #825

merged 1 commit into from
May 28, 2021

Conversation

xg-wang
Copy link
Member

@xg-wang xg-wang commented Apr 7, 2021

https://blog.emberjs.com/update-on-module-unification-and-octane/

Also run prettier, but the actual change only contains removing const isModuleUnification = this._isModuleUnification();

@xg-wang xg-wang added this to the ember-cli-fastboot v3 milestone Apr 7, 2021
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 🎉

@mansona mansona merged commit 0d11ef2 into master May 28, 2021
@xg-wang xg-wang deleted the drop-mu branch August 3, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants