Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and synchronize dependencies in the monorepo #886

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Update and synchronize dependencies in the monorepo #886

merged 1 commit into from
Jan 28, 2022

Conversation

SergeAstapov
Copy link
Contributor

No description provided.

mansona
mansona requested changes Jan 28, 2022
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just "requesting changes" on this because we probably need a discussion before it's ok to ship. And it's only one dependency on one project that I'm curious about too

packages/fastboot/package.json Show resolved Hide resolved
@mansona mansona merged commit be7ff2f into ember-fastboot:master Jan 28, 2022
@SergeAstapov SergeAstapov deleted the bump-deps branch January 28, 2022 17:34
@SergeAstapov
Copy link
Contributor Author

Discussed with @mansona and bumping jsdom should not be a concern as we use it only to parse an html for config/environment and manifest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SergeAstapov @mansona