Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and drop support for Node 12 #902

Merged
merged 5 commits into from
Dec 8, 2022
Merged

Conversation

mikrostew
Copy link
Contributor

Summary

Fix CI for this repo, which has been failing for the last few months, and run against Node 14.x and 16.x.

Updated Node LTS Versions

This drops support for Node 12.x (which is EOL as of 2022/04/30), and runs the tests against 14.x and 16.x.

I also pinned a more recent version of Yarn.

Notes
I had to update workerpool in the lockfile to pull in the fix for Node16 mentioned in this issue.

Legacy Mocha Tests

These have been failing for a while, with this error:

Error: Unable to require module 'crypto' because it was not in the whitelist.

So I added that to fastbootDependencies, which fixed the issue.

Notes
Running with Node 16 surfaced a new error with starting the server in the tests, so I removed the skipNpm: true option to fix that.

Ember-Try Tests

These have also been failing for a while, with this error:

Build Error (broccoli-persistent-filter:Babel > [Babel: @ember/test-helpers]) in @ember/test-helpers/-internal/build-registry.js

[BABEL]: Cannot find module 'babel-plugin-dynamic-import-node/utils'

I fixed that by preventing ember-try from running with --no-lockfile (which it does by default, and was causing a dependency mismatch when running the tests).

@mikrostew
Copy link
Contributor Author

I don't have permissions to run CI on this repo, but I was able to successfully run these changes against my fork: mikrostew#3

@ef4 ef4 added the breaking label Dec 8, 2022
@ef4 ef4 merged commit c02722b into ember-fastboot:master Dec 8, 2022
@ef4
Copy link
Contributor

ef4 commented Dec 8, 2022

Thanks, this looks OK so I'm going to merge it so it will actually get CI running again and you can see if it works.

@mikrostew mikrostew deleted the fix-ci branch December 8, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants