move to pnpm #917
Merged
move to pnpm #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
use-pnpm
branch
4 times, most recently
from
9e165d8
to
29ab224
Compare
kategengler
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've confirmed that this PR fails just as much as master does 馃槀 I compared the output of all the failing CI jobs from #918 to this one and it is the same.
I'm moving over to pnpm before I try to implement https://github.com/ef4/scenario-tester to clean up some of the failing tests
@kategengler If you felt like reviewing that would be appreciated 馃憤 (I couldn't add you as a reviewer because I don't think you're in the org 馃 we should probably fix that)