Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting is not linting... #33

Closed
jasonmit opened this issue Feb 9, 2015 · 7 comments
Closed

Linting is not linting... #33

jasonmit opened this issue Feb 9, 2015 · 7 comments

Comments

@jasonmit
Copy link
Member

jasonmit commented Feb 9, 2015

Likely a bug in ember-cli, but I need to do some investigating and send a PR to fix the issue.

Opening in an issue for tracking.

@zeppelin
Copy link
Contributor

zeppelin commented Feb 9, 2015

Well, .jshintrc is obviously missing from the repo. But even after I added it back with the below (ember-cli default) content, it didn't seem to help.

{
  "predef": [
    "document",
    "window",
    "-Promise"
  ],
  "browser": true,
  "boss": true,
  "curly": true,
  "debug": false,
  "devel": true,
  "eqeqeq": true,
  "evil": true,
  "forin": false,
  "immed": false,
  "laxbreak": false,
  "newcap": true,
  "noarg": true,
  "noempty": false,
  "nonew": false,
  "nomen": false,
  "onevar": false,
  "plusplus": false,
  "regexp": false,
  "undef": true,
  "sub": true,
  "strict": false,
  "white": false,
  "eqnull": true,
  "esnext": true,
  "unused": true
}

@jasonmit
Copy link
Member Author

jasonmit commented Feb 9, 2015

:) that will do it. Just saw the same thing. I'll fix it now and look into what is happening

@zeppelin
Copy link
Contributor

zeppelin commented Feb 9, 2015

Argh, silly me. Once already there, could you bump ember-cli-qunit to 0.3.4? :)
Almost 100% sure it'll fix the issue.

@jasonmit
Copy link
Member Author

jasonmit commented Feb 9, 2015

👍

@zeppelin
Copy link
Contributor

zeppelin commented Feb 9, 2015

Linting got extracted from the ember-cli main since 0.1.10: ember-cli/ember-cli#3122

jasonmit pushed a commit that referenced this issue Feb 9, 2015
jasonmit added a commit that referenced this issue Feb 10, 2015
[Bugfix] Enabling linting #33
@jasonmit
Copy link
Member Author

All fixed

@zeppelin
Copy link
Contributor

Wonderful 👍 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants