feat: filters invalid key types, throws when encountering one. #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmit
force-pushed
the
u/jasonmit/change-t-helper-key-validation
branch
from
21e6a8b
to
a3bc672
Compare
2 tasks
jasonmit
force-pushed
the
u/jasonmit/change-t-helper-key-validation
branch
from
a3bc672
to
48f9aa0
Compare
jasonmit
changed the title
jasonmit
changed the title
jasonmit
force-pushed
the
u/jasonmit/change-t-helper-key-validation
branch
from
48f9aa0
to
eb2a4a7
Compare
delete-merged-branch
bot
deleted the
u/jasonmit/change-t-helper-key-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some what related to #1299
Now we're validating the keys passed in and throw a more obvious exception when encountering one. Prior, you would have seen a compiler error thrown:
"A message must be provided as a String or AST"For consistency, the service
intl.t()API and the{{t}}helper now validate through the same path. That's the only breaking change here and I don't expect many to be impacted by it.