Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required locale in addTranslations() #1877

Merged
merged 4 commits into from
May 13, 2024
Merged

Required locale in addTranslations() #1877

merged 4 commits into from
May 13, 2024

Conversation

ijlee2
Copy link
Contributor

@ijlee2 ijlee2 commented May 13, 2024 •
edited

Why?

Follows up on #1847.

We can solve a few issues when we ask end-developers to specify the locale in addTranslations():

  • Reduce call variations from 2 to 1 (reduces the package size and maintenance cost).
  • Encourage people to write code that is explicit (helps onboard new developers).

@ijlee2 ijlee2 added the breaking Breaking change will result in a new major version label May 13, 2024
@ijlee2 ijlee2 marked this pull request as ready for review May 13, 2024 15:52
@ijlee2 ijlee2 merged commit aa95366 into main May 13, 2024
32 checks passed
@ijlee2 ijlee2 deleted the require-locale-in-addTranslations branch May 13, 2024 15:52
This was referenced May 13, 2024
Closed
Merged
ijlee2 added a commit that referenced this pull request May 14, 2024
@ijlee2
Patched #1877 and #1882 (#1883)
ca107f3 
* bugfix: Restricted type for the test helper setLocale()

* bugfix: Applied an extra optional chanining to avoid runtime error

* chore: Added changeset

---------

Co-authored-by: ijlee2 <ijlee2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Breaking change will result in a new major version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ijlee2