-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Locale modules now extend from a Locale model (WIP) #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This locale model implements a intlGetAccessor method so you can implement your own getter accessor logic. This is the method invoked from intl-get and intl-get no longer acts on the service, but instead the active locale module instance. It should resolve #24 #23 All existing locale modules no longer can be POJOs and should extend from: `import Locale from 'ember-intl/models/locale’;`
jasonmit
changed the title
[Breaking] Locale modules now extend from Locale model
[Breaking] Locale modules now extend from a Locale model
Feb 7, 2015
Also renaming intlGetAccessor to accessor
jasonmit
changed the title
[Breaking] Locale modules now extend from a Locale model
[Breaking] Locale modules now extend from a Locale model (WIP)
Feb 7, 2015
jasonmit
force-pushed
the
intl-get-accesor
branch
7 times, most recently
from
February 8, 2015 07:12
dfe1e1c
to
5f67161
Compare
jasonmit
force-pushed
the
intl-get-accesor
branch
from
February 8, 2015 07:13
5f67161
to
d709fa2
Compare
jasonmit
force-pushed
the
intl-get-accesor
branch
from
February 9, 2015 04:15
6eedd0d
to
8268e8c
Compare
Thanks for adding the smoke tests @zeppelin, I've also added you as a contributor in package.json 👍 I fixed the failing test issues and will likely merge this shortly. |
jasonmit
added a commit
that referenced
this pull request
Feb 9, 2015
[Breaking] Locale modules now extend from a Locale model (WIP)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addMessages
andaddMessage
to the intl service and which delegates to the locale moduleThis is extensible if you do not want your messages to hang off "messages" on the locale module. You can override
addMessage
/addMessages
on the locale model.It will resolve #24 #23 #18
All existing locale modules no longer can be POJOs and should extend from:
import Locale from 'ember-intl/models/locale’;