Implementing new CLDR extracting #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for ember-intl to be easily extended for complex use-cases. For example, hitting an API for fetching translations.
|
CLA is valid! |
| normalizeEntityName: function (localeName) { | ||
| entityName = Blueprint.prototype.normalizeEntityName.apply(this, arguments); | ||
|
|
||
| if (!extract.isValidLocale(localeName)) { | ||
| if (!cldrLocales.locales.has(localeName)) { |
| return fullName.toLowerCase(); | ||
| } | ||
|
|
||
| export default IntlAdapter.extend({ |
There was a problem hiding this comment.
Not documenting this yet, but it will eventually be exposed for those people who want to specify their own way of loading translations. The CLDR portion of this hasn't been thought out yet, but it will ideally be another hook off this.
See: #69
| "intl": "0.1.4", | ||
| "intl-messageformat": "1.0.4", | ||
| "intl-messageformat": "1.1.0", | ||
| "intl-relativeformat": "1.0.3", |
There was a problem hiding this comment.
I plan to bump this now that you published
| } | ||
|
|
||
| if (result.fields) { | ||
| data.push(' fields: ' + serialize(result.fields) + ','); |
There was a problem hiding this comment.
You can build up a JSON/JavaScript object and then call serialize() once for the whole thing.
jasonmit
added a commit
that referenced
this pull request
Mar 15, 2015
Implementing new CLDR extracting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet complete, waiting on relative format npm publish, but verified everything works locally.