[Enhancement] Throw when intl-get is used standalone #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
| @@ -175,7 +175,7 @@ export default Ember.Service.extend(Ember.Evented, { | |||
| } | |||
| }, | |||
|
|
|||
| getLanguage: function (locale) { | |||
| findLanguage: function (locale) { | |||
There was a problem hiding this comment.
These are not yet documented and private, I am changing them to match what gets invoked on the adapter for consistency. In 1.3.0 I plan to document this and mark it as public.
| @@ -7,6 +7,8 @@ import Ember from 'ember'; | |||
| import { Stream, read, readHash, destroyStream } from 'ember-intl/utils/streams'; | |||
|
|
|||
| export default function (value, options) { | |||
| Ember.assert('intl-get helper must be used as a subexpression', options.isInline === true); | |||
There was a problem hiding this comment.
Future versions I plan to deprecate intl-get with a warning in favor of a t helper. Intl-get no longer shares the same concepts of its sibling libs since it only is used to resolve translations keys.
(intl-get 'messages.foo.bar') will become (t 'foo.bar')
In 2.0 I plan to remove intl-get all together. This will coincide with renaming locales -> translations and build in the "merging", at build time, of the fallback locale into all other known locales.
jasonmit
added a commit
that referenced
this pull request
Mar 26, 2015
[Enhancement] Throw when intl-get is used standalone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84