Skip to content
This repository has been archived by the owner on Jun 13, 2019. It is now read-only.

Update install instructions #47

Closed
locks opened this issue Oct 7, 2017 · 5 comments
Closed

Update install instructions #47

locks opened this issue Oct 7, 2017 · 5 comments

Comments

@locks
Copy link
Collaborator

locks commented Oct 7, 2017

We are still showing bower instructions for installing Ember into your application, example: emberjs/website#3008.
This instruction should be switched to use the ember-source npm package.

@AnupKumarGupta
Copy link

Hello, I want to work on this. Please let me know how to get started.

@locks
Copy link
Collaborator Author

locks commented Oct 9, 2017

@AnupKumarGupta thanks for the interest!

We need to update the file with the information on Ember releases to match Ember Data.
https://github.com/ember-learn/builds/blob/master/app/fixtures/ember/release.js#L16 This is the Ember line that needs to be changed.
https://github.com/ember-learn/builds/blob/master/app/fixtures/ember-data/release.js#L12 This is the Ember Data line that is using npm that you can take inspiration from.

@jkumar712
Copy link
Contributor

jkumar712 commented Oct 11, 2017

@locks If it is still open, Can I open PR for this? I made necessary changes and have a PR!

@RobbieTheWagner
Copy link
Member

@locks we can close this now right?

@locks
Copy link
Collaborator Author

locks commented Feb 6, 2018

Yup, thanks!

@locks locks closed this as completed Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants