Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add writeup on MDN #663

Merged
merged 2 commits into from
May 29, 2020
Merged

Add writeup on MDN #663

merged 2 commits into from
May 29, 2020

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented May 29, 2020

@NullVoxPopuli if you have time to take a look, let me know if any edits! No worries if not. I haven't done the tutorial yet, but it looks awesome!

@amyrlam amyrlam requested review from NullVoxPopuli and a team May 29, 2020 02:04
@NullVoxPopuli
Copy link
Contributor

looks great! thanks <3

@amyrlam
Copy link
Member Author

amyrlam commented May 29, 2020

@NullVoxPopuli really appreciate the readover! 🙏

Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you both for your work!

Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label May 29, 2020
@amyrlam
Copy link
Member Author

amyrlam commented May 29, 2020

🙇‍♀️ much appreciated @ijlee2!

@amyrlam amyrlam merged commit ba629f8 into blog/embertimes-150 May 29, 2020
@amyrlam amyrlam deleted the amy/mdn branch May 29, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants