-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub-dependency of JSDom, ip-regex, is not compatible with Node v6 #298
Comments
There's no reason we can't make sure the migration code loads lazily, such that it has no impact on you if you aren't migrating. |
We would have to make the dependencies |
Unless someone is volunteering to take on that work that seems more complex & time consuming. I'm all for pointing folks to an earlier version as an interim upgrade step. |
We're in the home stretch for Node 6, but this is definitely painful for anyone who's still (rightly!) testing their addons against it in CI. It looks like @simonihmig opened a PR to |
Yes, but unsure how quickly this will get released... I used |
Could y'all weigh on in #302? |
A subdependency of this addon is no longer compatible with ip-regex. It's possible to work around this for the moment with
resolutions
in package.json, but it may eventually become more problematic.It looks like the JSDom dependency was added as part of @savvymas and @ef4's migration script, which I think could be removed at this point. If folks still need to update, we could point them to first updating to a previous version of
ec-addon-docs
and then to the current version.The text was updated successfully, but these errors were encountered: