Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-dependency of JSDom, ip-regex, is not compatible with Node v6 #298

Closed
pzuraq opened this issue Jan 11, 2019 · 7 comments
Closed

Sub-dependency of JSDom, ip-regex, is not compatible with Node v6 #298

pzuraq opened this issue Jan 11, 2019 · 7 comments

Comments

@pzuraq
Copy link
Contributor

pzuraq commented Jan 11, 2019

A subdependency of this addon is no longer compatible with ip-regex. It's possible to work around this for the moment with resolutions in package.json, but it may eventually become more problematic.

It looks like the JSDom dependency was added as part of @savvymas and @ef4's migration script, which I think could be removed at this point. If folks still need to update, we could point them to first updating to a previous version of ec-addon-docs and then to the current version.

@pzuraq
Copy link
Contributor Author

pzuraq commented Jan 11, 2019

See this issue for more details

@ef4
Copy link
Contributor

ef4 commented Jan 11, 2019

There's no reason we can't make sure the migration code loads lazily, such that it has no impact on you if you aren't migrating.

@pzuraq
Copy link
Contributor Author

pzuraq commented Jan 11, 2019

We would have to make the dependencies optionalDependencies, since the failure will occur even before install finishes if the engine conflict is detected. I think that could work.

@samselikoff
Copy link
Contributor

Unless someone is volunteering to take on that work that seems more complex & time consuming. I'm all for pointing folks to an earlier version as an interim upgrade step.

@dfreeman
Copy link
Contributor

We're in the home stretch for Node 6, but this is definitely painful for anyone who's still (rightly!) testing their addons against it in CI. It looks like @simonihmig opened a PR to tough-cookie to constrain the ip-regex dependency; if that goes through soon, we may not have to take action here.

@simonihmig
Copy link

Yes, but unsure how quickly this will get released... I used resolutions to "fix" it for now, but FWIW for my addon jsdom was just a devDependency...

@samselikoff
Copy link
Contributor

Could y'all weigh on in #302?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants