-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis builds fail with node 6 and yarn #8360
Comments
Can you say more? Do you mean that ember-cli itself is failing, apps are failing, addons are failing, etc? |
@rwjblue this was a couple of my addon builds, but this could be an issue with any project generated with ember-cli, I think. Seems like a dependency of a dependency,
|
In one of the affected systems can you |
@rwjblue the output from that seems to be empty, so no idea 😂 You can see the error in the build here https://travis-ci.org/shipshapecode/ember-math-helpers/jobs/478394676 Something in travis specifically must be pulling it in. It's not in my local yarn.lock |
@rwwagner90 makes sense, note that CI is running |
I believe that this is the same issue that @pzuraq and I were chatting about last night. Basically a nested dependency of See ember-decorators/ember-decorators#375 for a handy work around. |
Ran into this same dependency,
|
this is caused by salesforce/tough-cookie#140 |
Closing here as there isn't much we can do about it in ember-cli itself... |
@rwjblue I was thinking we could add |
I'm not really in favor 🤔. Hiding the failure doesn't actually fix it... |
@rwjblue sure thing. I think, in a lot of cases, engines are somewhat arbitrary though, and things really work still, but I suppose it's safer to not ignore the failure, so never mind 😃 |
It seems that ip-regex sets an engine that is not compatible with node 6, which we use for travis tests.
error ip-regex@3.0.0: The engine "node" is incompatible with this module. Expected version ">=8". Got "6.16.0"
Should we add
--ignore-engines
to the yarn install to avoid this sort of thing in the future? If so, I am happy to open a PR.Output from
ember version --verbose && npm --version && yarn --version
:The text was updated successfully, but these errors were encountered: