Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-modal-dialog 4.0.0-alpha.0, Drop support for <=Ember 3.19, Node 10 #842

Merged
merged 3 commits into from
May 25, 2021
Merged

Conversation

elwayman02
Copy link
Contributor

@elwayman02 elwayman02 commented May 25, 2021

Ran yarn test:ember, yarn test:node, and yarn test:test-apps locally to confirm no failures.

* Fixes version mismatch for ember-wormhole. This was causing a mismatch between babel 6 & 7 in consuming apps, which created build errors.
* This should probably require a major release, since ember-modal-dialog 4.0.0-alpha.0 has symobolically (but not technically) dropped support for <= Ember 3.19: yapplabs/ember-modal-dialog#332
@elwayman02
Copy link
Contributor Author

elwayman02 commented May 25, 2021

I'm not able to restart the builds. It seems they were passing but one of them encountered a hiccup installing ember-source and that caused the rest to get canceled. Pushing an empty commit to trigger the builds again.

@elwayman02 elwayman02 changed the title Bump ember-modal-dialog ember-modal-dialog 4.0.0-alpha.0, Drop support for <=Ember 3.19, Node 10 May 25, 2021
@elwayman02
Copy link
Contributor Author

elwayman02 commented May 25, 2021

Updated the PR title to make it more descriptive for any CHANGELOG auto-generation.

@elwayman02
Copy link
Contributor Author

@rwwagner90 please review when you have the chance, thank you! :)

@RobbieTheWagner RobbieTheWagner merged commit a2c1eef into ember-learn:master May 25, 2021
@elwayman02 elwayman02 deleted the fix-wormhole branch May 25, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants