This repository has been archived by the owner on Jul 4, 2019. It is now read-only.
Add in all Ember repos to be tracked #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let repoHash = {}; | ||
|
|
||
| repoList.map(repo => { | ||
| repoHash[repo] = { labels: standardLabels }; |
There was a problem hiding this comment.
Hmm, I like the idea of using standard labels, but would also like to have an "out" for repos that don't use the labels we're using yet. I don't want to force folks to have to adopt our label standards in order to use the tool. Thoughts?
There was a problem hiding this comment.
Well projects that don't have standard labels yet can directly define their repo inside the repoHash. But unless we want to maintain internal aliasing to group different names given for a label with same intent, we might have to nudge them to adapt to standard labels. I don't see all types of labels coming here anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9