Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write some real acceptance tests #22

Closed
acorncom opened this issue May 12, 2016 · 6 comments
Closed

Write some real acceptance tests #22

acorncom opened this issue May 12, 2016 · 6 comments
Labels
Help Wanted Extra attention is needed
Milestone

Comments

@acorncom
Copy link
Member

No description provided.

@acorncom acorncom added the Help Wanted Extra attention is needed label May 12, 2016
@acorncom acorncom added this to the MVP milestone May 12, 2016
@julienfitz
Copy link

Do you have anything in mind for the kinds of tests you'd like to see? I notice there don't appear to be any at the moment, but just thought I'd check before I start writing anything 😛

@acorncom
Copy link
Member Author

As I think about it, writing any acceptance tests right now is likely to be a major pain, due to EmberFire's lack of test support :-/ We're considering changing out the backend to something that would handle querying better, so it may be best to just wait on this temporarily ... Thanks though!

@villander
Copy link

@acorncom And the acceptance tests with mirage? They are very real. Can I write acceptance tests with mirage?

@acorncom
Copy link
Member Author

@villander Yes, we'd love to see acceptance tests written with Mirage, it's part of the reason we shifted from using EmberFire! 😀

@ppcano
Copy link
Contributor

ppcano commented Sep 8, 2018

@hakilebara If none has taken this issue, I can write the acceptance tests.

@MelSumner MelSumner added the Hacktoberfest Issue counts towards Hacktoberfest label Oct 4, 2018
@EndangeredMassa EndangeredMassa removed the Hacktoberfest Issue counts towards Hacktoberfest label Nov 18, 2018
@ppcano
Copy link
Contributor

ppcano commented Dec 1, 2018

@MelSumner I think #77 should have closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants