Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the browser support policy page #1088

Merged

Conversation

NullVoxPopuli
Copy link
Contributor

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit b84f392
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/663b9ec00e30e400087ba88c
😎 Deploy Preview https://deploy-preview-1088--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

<h2>Ember 6.0.0</h2>

<p>
In Ember 6.0.0, the framework supports the following major browsers:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ember 6 isn't out yet, so I'm not sure what we want to do here -- or maybe this whole section could be omitted until ember 6?

especially since the versions below on lines 16-19 are likely to change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe omit this section until 6.0 exists -- the policy below is enough

mansona
mansona previously requested changes Mar 6, 2024
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment but I'm also "requesting changes" because we won't be merging this until ember@6 is released. We can keep this PR to remember that we need to merge it but it should be added to some sort of list of things to do for v6 👍

app/templates/browser-support.hbs Outdated Show resolved Hide resolved
@achambers
Copy link
Contributor

NullVoxPopuli#2

@NullVoxPopuli NullVoxPopuli force-pushed the update-safari-support-prepare-ember-v6 branch from 2175614 to eefa8cc Compare May 3, 2024 18:20
@mansona mansona dismissed their stale review May 3, 2024 18:20

this has been re-worked since my review

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullVoxPopuli mentions that he's not sure what to do about the future reference to an unreleased Ember version. I think we need to be very careful about how we phrase this. I'm requesting changes on this but I'm also committing to pair with @NullVoxPopuli to get the phrasing on this right 👍

@NullVoxPopuli NullVoxPopuli changed the title Amend the browser support policy for Safari Update the browser support policy page to make updating #984 May 8, 2024
@NullVoxPopuli NullVoxPopuli changed the title Update the browser support policy page to make updating #984 Update the browser support policy page to make updating for #984 easier May 8, 2024
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is significantly improving the whole page and now effectively links to the future changes in the support policy 🎉

@mansona mansona changed the title Update the browser support policy page to make updating for #984 easier Update the browser support policy page May 8, 2024
@mansona mansona merged commit 17d01eb into ember-learn:main May 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants