Update links and prose on Learn page #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
changed the title
|
Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
MelSumner
requested changes
May 10, 2020
|
@locks I'd love to move this PR forward when you get a chance. |
|
@MelSumner resolved ember-animated and the conflict with master! |
|
Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
|
Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
|
Files that got Bigger 🚨:
Files that got Smaller 🎉:
Files that stayed the same size 🤷:
|
jaredgalanis
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
@locks LGTM 👍 . I made one fix. Although I'm not sure why the images are not loading in time for the percy snapshots. Approving conditionally in the event that you know more and determine that it doesn't matter.
MelSumner
approved these changes
Jun 3, 2020
|
Thank you for the reviews, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.