Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design related sidebar refinements #47

Closed
1 of 3 tasks
nickschot opened this issue Jun 4, 2020 · 0 comments · Fixed by #48
Closed
1 of 3 tasks

Design related sidebar refinements #47

nickschot opened this issue Jun 4, 2020 · 0 comments · Fixed by #48
Assignees
@nickschot
Labels
design
Projects
Emberify and Redesign the Ember Blog

Comments

@nickschot
Copy link
Contributor

nickschot commented Jun 4, 2020 •
edited
Loading

  • Implement proper design for the header of the overlay no changes for now
  • decide on a closing animation decided to not add one
  • add a proper icon for the close button (rather than just an X)
@nickschot nickschot self-assigned this Jun 4, 2020
@mansona mansona mentioned this issue Jun 4, 2020
Closed
3 tasks
@mansona mansona added this to To do in Emberify and Redesign the Ember Blog via automation Jun 4, 2020
@mansona mansona added the design label Jun 4, 2020
@nickschot nickschot mentioned this issue Jun 11, 2020
Merged
@nickschot nickschot moved this from To do to Needs review in Emberify and Redesign the Ember Blog Jun 11, 2020
Emberify and Redesign the Ember Blog automation moved this from Needs review to Done Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickschot nickschot

Labels
design
Projects
No open projects
Emberify and Redesign the Ember Blog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add close icon to sidebar, make button square ember-learn/empress-blog-ember-template
2 participants
@nickschot @mansona