Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility related sidebar refinements #43

Closed
1 of 3 tasks
mansona opened this issue May 14, 2020 · 3 comments · Fixed by #44
Closed
1 of 3 tasks

Accessibility related sidebar refinements #43

mansona opened this issue May 14, 2020 · 3 comments · Fixed by #44

Comments

@mansona
Copy link
Member

mansona commented May 14, 2020

This is a follow on issue to #23 that aims to list of of the things necessary to get the sidebar ready for release 👍

@nickschot
Copy link
Contributor

nickschot commented May 21, 2020

As I can't edit the above here's a list of accessibility points:

  • move focus to the <nav> container when it is opened (preferably without tab index)
  • add aria-expanded to the nav
  • remove title from toggle sidebar/close button
  • add aria-hidden=true to the SVGs
  • remove role=complementary from nav element
  • remove the second header - only use one header per site
  • add aria-label to the nav elements
    • e.g. header → "Primary site navigation"
    • e.g. sidebar → "Sidebar content navigation"

@nickschot
Copy link
Contributor

Focus already seems to automatically be on the sidebar when opened (first tab selects top most focusable item in the sidebar). Is this good enough? Do we want actual focus trapping? Implementing that is slightly more involved as it has to be disabled for non-mobile.

@nickschot
Copy link
Contributor

We'll have to add the "Primary site navigation" aria-label in styleguide itself.

@nickschot nickschot changed the title Sidebar refinements Accessibility related sidebar refinements Jun 4, 2020
Emberify and Redesign the Ember Blog automation moved this from In progress to Done Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants