-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility related sidebar refinements #43
Comments
As I can't edit the above here's a list of accessibility points:
|
Focus already seems to automatically be on the sidebar when opened (first tab selects top most focusable item in the sidebar). Is this good enough? Do we want actual focus trapping? Implementing that is slightly more involved as it has to be disabled for non-mobile. |
We'll have to add the "Primary site navigation" aria-label in styleguide itself. |
This is a follow on issue to #23 that aims to list of of the things necessary to get the sidebar ready for release 👍
Implement proper design for the header of the overlaymoved to Design related sidebar refinements #47decide on a closing animationmoved to Design related sidebar refinements #47The text was updated successfully, but these errors were encountered: