Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement post-card design #51

Merged
merged 1 commit into from
Jun 12, 2020
Merged

implement post-card design #51

merged 1 commit into from
Jun 12, 2020

Conversation

nickschot
Copy link
Contributor

@nickschot nickschot commented Jun 11, 2020 •
edited
Loading

closes #25
Screenshot 2020-06-11 at 11 05 33

@nickschot nickschot requested a review from mansona June 11, 2020 09:05
@nickschot
Copy link
Contributor Author

<hr/> is not styled here and should be implemented in styleguide. See ember-learn/ember-styleguide#329

@mansona mansona added this to In progress in Emberify and Redesign the Ember Blog via automation Jun 11, 2020
@mansona mansona moved this from In progress to Needs review in Emberify and Redesign the Ember Blog Jun 11, 2020
Emberify and Redesign the Ember Blog automation moved this from Needs review to Reviewer approved Jun 12, 2020
mansona
mansona approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 🎉 thanks for doing this

@mansona mansona merged commit a9ead2b into master Jun 12, 2020
Emberify and Redesign the Ember Blog automation moved this from Reviewer approved to Done Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Emberify and Redesign the Ember Blog
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PostCard component
2 participants
@nickschot @mansona