Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close sidebar after a route transition #65

Merged
merged 1 commit into from
Jul 30, 2020
Merged

close sidebar after a route transition #65

merged 1 commit into from
Jul 30, 2020

Conversation

nickschot
Copy link
Contributor

@nickschot nickschot commented Jul 16, 2020

This is the least invasive implementation which works without modification of the content. The only case where it doesn't close is if you click on a link which matches the current page.

@nickschot nickschot requested a review from mansona July 16, 2020 13:30
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🎉

@mansona mansona merged commit fe03019 into master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants