Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace last moment usages & remove moment dependency #98

Merged
merged 1 commit into from
Dec 13, 2020
Merged

replace last moment usages & remove moment dependency #98

merged 1 commit into from
Dec 13, 2020

Conversation

nickschot
Copy link
Contributor

a moment like this

a moment like this

Replaces the last 2 usages of moment with native alternatives & removes the moment dependency itself.

locks
locks approved these changes Dec 12, 2020
View reviewed changes
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

mansona
mansona approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need to do some tweaking on the output of the date URL so that it doesn't move on timezones but otherwise this is an amazing change 😍

@mansona mansona merged commit b2bd31c into master Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks approved these changes

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickschot @locks @mansona