Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: make on-this-page sticky #184

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

IgnaceMaes
Copy link
Member

@IgnaceMaes IgnaceMaes commented Feb 21, 2024

Implements part of #182

Makes the "On This Page" section sticky

Test: https://deploy-preview-184--guidemaker-ember-template.netlify.app/release/guide-test

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for guidemaker-ember-template ready!

Name Link
🔨 Latest commit 923f049
🔍 Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/65d73476ee46f200089703b9
😎 Deploy Preview https://deploy-preview-184--guidemaker-ember-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mansona
Copy link
Member

mansona commented Feb 22, 2024

This looks great! I think you need to just update tests since you added a new page 👍

@IgnaceMaes
Copy link
Member Author

Ah good catch, updated!

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉 :shipit:

@mansona mansona merged commit 4b55862 into ember-learn:main Feb 22, 2024
13 of 17 checks passed
@github-actions github-actions bot mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants