[2.18] Code examples for Testing seem different from reality

[peabnuts123]

I am quite confused here and presumably looking to be told why I am wrong. I have been reviewing the guides for Testing, but none of the code examples match what is generated in my ember app. This has been very confusing for me because the code examples on the guides look way more legit.

For example, I am reviewing this page on writing acceptance tests. The code example on the page is as follows:

// tests/acceptance/login-test.js

import { module, test } from 'qunit';
import { visit } from '@ember/test-helpers';
import { setupApplicationTest } from 'ember-qunit';

module('Acceptance | login', function(hooks) {
  setupApplicationTest(hooks);

  test('visiting /login', async function(assert) {
    await visit('/login');
    assert.equal(currentURL(), '/login');
  });
});

However, if I generate exactly the same test locally I get the following:

// tests/acceptance/login-test.js

import { test } from 'qunit';
import moduleForAcceptance from 'my-app/tests/helpers/module-for-acceptance';

moduleForAcceptance('Acceptance | login');

test('visiting /login', function(assert) {
  visit('/login');

  andThen(function() {
    assert.equal(currentURL(), '/login');
  });
});

I can see this output in the guides up to 2.17 but they seem to change at 2.18.
Digging around, I have found the blueprints source in the Ember.js repo, but much to my dismay, the blueprints agree with what is being generated locally. In fact, the blueprints agree with me even on latest release 3.3.0-beta4.

What are the testing guides on about?

[acorncom]

@peabnuts123 The testing framework did change in Ember 3.0, but it should have been left unchanged in Ember 2.18. We may have goofed on that somehow as we released a new version of the guides ...

Details on the changes can be found on the Ember 3.0 blog post (https://emberjs.com/blog/2018/02/14/ember-3-0-released.html#toc_updates-to-the-testing-defaults).

As far as the blueprints go, you're right but you're not 😉 The acceptance test blueprints have been updated when you look at the rfc-232 blueprints here: https://github.com/emberjs/ember.js/tree/v3.0.0/blueprints/acceptance-test

Does that help?

[acorncom]

For anyone interested in helping, we'd love to see the Ember 2.17 testing guides copied over to Ember 2.18 in this repo so we eliminate the confusion here. @peabnuts123 if you have time, a PR would be great, otherwise we'll see about getting this cleaned up in a bit.

[peabnuts123]

This makes sense. I went on to learn about the testing overhauls that have happened but left the issue open as the contents of node_modules/ember-source did not have the RFC-232 blueprints in it and I was thoroughly confused. Thanks for the info! I may or may not have time to put together a PR, I am unsure.
Question for you, @acorncom, can I use the new test formats / get my hands on the blueprints without upgrading to 3.0? I'm really loving the changes that have been made.

[peabnuts123]

Have opened #102. Please take a look and see if it is correct.

[acorncom]

Closed by #102 Thanks again!